From xen-devel-bounces@lists.xen.org Wed May 29 16:02:42 2013 Received: (at maildrop) by bugs.xenproject.org; 29 May 2013 15:02:42 +0000 Received: from lists.xen.org ([50.57.142.19]) by bugs.xenproject.org with esmtp (Exim 4.80) (envelope-from ) id 1Uhhti-0001bp-52 for xen-devel-maildrop-Eithu9ie@bugs.xenproject.org; Wed, 29 May 2013 16:02:42 +0100 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1UhhsK-0001N8-RX; Wed, 29 May 2013 15:01:16 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1UhhsI-0001Mt-P0 for xen-devel@lists.xen.org; Wed, 29 May 2013 15:01:15 +0000 Received: from [193.109.254.147:57547] by server-4.bemta-14.messagelabs.com id A4/33-29620-A3816A15; Wed, 29 May 2013 15:01:14 +0000 X-Env-Sender: dunlapg@gmail.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1369839664!3852346!1 X-Originating-IP: [74.125.82.175] X-SpamReason: No, hits=2.0 required=7.0 tests=BIZ_TLD,RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 6.9.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13346 invoked from network); 29 May 2013 15:01:05 -0000 Received: from mail-we0-f175.google.com (HELO mail-we0-f175.google.com) (74.125.82.175) by server-10.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 29 May 2013 15:01:05 -0000 Received: by mail-we0-f175.google.com with SMTP id p60so6512094wes.34 for ; Wed, 29 May 2013 08:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=4m7+j0V4FU6l/Gzl7UaHpBkQvyH52mkIrVG6HLCQrAM=; b=fOHyVSESYm3UpckB+579RG/gvAa76gLNSieG48NoNJNadjoQyNDgMrGnrHJyIZ98qL U57eKrlvGzEVDxPIQxkakrCkLjpiEO0tyfGU4Tia+gpnhM5HlGbu07xVvMDJh3EVUXe3 TUVHQ07U0Sw9dwFiJdquBklr0X8eKRH6mylpsr3O7DFpXDBOm7soEaX76F4vZ3V7y1J2 BMFoudaqwU74rzEiFpT8s1JaaJJIU7Sih7c69LtkkI79rf/QG89IRUqLITMFY4NZmzKS DfWhAoid64cBMwoWaLNoQLiLjoEFjJARjR+cCFu4IfRl5y8qORWmnjYYKkOq+cWj26RX Mqrw== MIME-Version: 1.0 X-Received: by 10.194.123.69 with SMTP id ly5mr1885141wjb.29.1369839664653; Wed, 29 May 2013 08:01:04 -0700 (PDT) Received: by 10.194.103.40 with HTTP; Wed, 29 May 2013 08:01:04 -0700 (PDT) In-Reply-To: <1369408859-2929-1-git-send-email-george.dunlap@eu.citrix.com> References: <1369408859-2929-1-git-send-email-george.dunlap@eu.citrix.com> Date: Wed, 29 May 2013 16:01:04 +0100 X-Google-Sender-Auth: OvUQ19F0kgUlwYvu171zWfmnBng Message-ID: From: George Dunlap To: "xen-devel@lists.xen.org" , xenbugs Cc: George Dunlap , Ian Jackson , Fabio Fantoni , Ian Campbell Subject: Re: [Xen-devel] [PATCH] libxl: Remove qxl support for the 4.3 release X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org create ^ title -1 qxl hypervisor support thanks On Fri, May 24, 2013 at 4:20 PM, George Dunlap wrote: > The qxl drivers for Windows and Linux end up calling instructions > that cannot be used for MMIO at the moment. Just for the 4.3 release, > remove qxl support. > > This patch should be reverted as soon as the 4.4 development window opens. > > The issue in question: > > (XEN) emulate.c:88:d18 bad mmio size 16 > (XEN) io.c:201:d18 MMIO emulation failed @ 0033:7fd2de390430: f3 0f 6f > 19 41 83 e8 403 > > The instruction in question is "movdqu (%rcx),%xmm3". Xen knows how > to emulate it, but unfortunately %xmm3 is 16 bytes long, and the interface > between Xen and qemu at the moment would appear to only allow MMIO accesses > of 8 bytes. > > It's too late in the release cycle to find a fix or a workaround. > > Signed-off-by: George Dunlap > CC: Ian Jackson > CC: Ian Campbell > CC: Fabio Fantoni > --- > docs/man/xl.cfg.pod.5 | 10 +--------- > tools/libxl/libxl_create.c | 16 ---------------- > tools/libxl/libxl_dm.c | 13 ------------- > tools/libxl/libxl_types.idl | 1 - > tools/libxl/xl_cmdimpl.c | 2 -- > 5 files changed, 1 insertion(+), 41 deletions(-) > > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 > index e0c3bb2..a0c7430 100644 > --- a/docs/man/xl.cfg.pod.5 > +++ b/docs/man/xl.cfg.pod.5 > @@ -1005,9 +1005,6 @@ the amount of video ram is fixed at 4MB which is sufficient > for 1024x768 at 32 bpp and videoram option is currently working > only when using the upstream qemu-xen device-model. > > -For B vga, the default is both default and minimal 128MB. > -If B is set less than 128MB, an error will be triggered. > - > =item B > > Select a standard VGA card with VBE (VESA BIOS Extensions) as the > @@ -1019,14 +1016,9 @@ This option is deprecated, use vga="stdvga" instead. > > =item B > > -Selects the emulated video card (stdvga|cirrus|qxl). > +Selects the emulated video card (stdvga|cirrus). > The default is cirrus. > > -In general, QXL should work with the Spice remote display protocol > -for acceleration, and QXL driver is necessary in guest in this case. > -QXL can also work with the VNC protocol, but it will be like a standard > -VGA without acceleration. > - > =item B > > Allow access to the display via the VNC protocol. This enables the > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > index cb9c822..0c32d0b 100644 > --- a/tools/libxl/libxl_create.c > +++ b/tools/libxl/libxl_create.c > @@ -213,22 +213,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, > if (b_info->shadow_memkb == LIBXL_MEMKB_DEFAULT) > b_info->shadow_memkb = 0; > > - if (b_info->u.hvm.vga.kind == LIBXL_VGA_INTERFACE_TYPE_QXL) { > - if (b_info->device_model_version == > - LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) { > - if (b_info->video_memkb == LIBXL_MEMKB_DEFAULT) { > - b_info->video_memkb = (128 * 1024); > - } else if (b_info->video_memkb < (128 * 1024)) { > - LOG(ERROR, > - "128 Mib videoram is the minimum for qxl default"); > - return ERROR_INVAL; > - } > - } else { > - LOG(ERROR,"qemu upstream required for qxl vga"); > - return ERROR_INVAL; > - } > - } > - > if (b_info->u.hvm.vga.kind == LIBXL_VGA_INTERFACE_TYPE_STD && > b_info->device_model_version == > LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) { > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index d10a58f..4e56ffa 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -191,8 +191,6 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc, > break; > case LIBXL_VGA_INTERFACE_TYPE_CIRRUS: > break; > - case LIBXL_VGA_INTERFACE_TYPE_QXL: > - break; > } > > if (b_info->u.hvm.boot) { > @@ -479,17 +477,6 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, > libxl__sizekb_to_mb(b_info->video_memkb)), NULL); > } > break; > - case LIBXL_VGA_INTERFACE_TYPE_QXL: > - /* QXL have 2 ram regions, ram and vram */ > - flexarray_vappend(dm_args, "-vga", "qxl", NULL); > - if (b_info->video_memkb) { > - flexarray_vappend(dm_args, "-global", > - GCSPRINTF("qxl-vga.vram_size_mb=%"PRIu64, > - (b_info->video_memkb/2/1024)), "-global", > - GCSPRINTF("qxl-vga.ram_size_mb=%"PRIu64, > - (b_info->video_memkb/2/1024)), NULL); > - } > - break; > } > > if (b_info->u.hvm.boot) { > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > index 8262cba..d218a2d 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl > @@ -130,7 +130,6 @@ libxl_shutdown_reason = Enumeration("shutdown_reason", [ > libxl_vga_interface_type = Enumeration("vga_interface_type", [ > (1, "CIRRUS"), > (2, "STD"), > - (3, "QXL"), > ], init_val = 0) > > # > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index e13a64e..148320c 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -1456,8 +1456,6 @@ skip_vfb: > b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_STD; > } else if (!strcmp(buf, "cirrus")) { > b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_CIRRUS; > - } else if (!strcmp(buf, "qxl")) { > - b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_QXL; > } else { > fprintf(stderr, "Unknown vga \"%s\" specified\n", buf); > exit(1); > -- > 1.7.9.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel