From xen-devel-bounces@lists.xen.org Mon Feb 17 15:10:21 2014 Received: (at maildrop) by bugs.xenproject.org; 17 Feb 2014 15:10:21 +0000 Received: from lists.xen.org ([50.57.142.19]) by bugs.xenproject.org with esmtp (Exim 4.80) (envelope-from ) id 1WFPpt-0001tX-Sf for xen-devel-maildrop-Eithu9ie@bugs.xenproject.org; Mon, 17 Feb 2014 15:10:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WFPkr-0002kN-GB; Mon, 17 Feb 2014 15:05:09 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WFPkq-0002kE-2D for xen-devel@lists.xen.org; Mon, 17 Feb 2014 15:05:08 +0000 Received: from [85.158.139.211:27992] by server-10.bemta-5.messagelabs.com id E5/C4-08578-32522035; Mon, 17 Feb 2014 15:05:07 +0000 X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-11.tower-206.messagelabs.com!1392649506!4468684!1 X-Originating-IP: [130.57.49.28] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTMwLjU3LjQ5LjI4ID0+IDQ4MDU=\n X-StarScan-Received: X-StarScan-Version: 6.9.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 26819 invoked from network); 17 Feb 2014 15:05:06 -0000 Received: from nat28.tlf.novell.com (HELO nat28.tlf.novell.com) (130.57.49.28) by server-11.tower-206.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 17 Feb 2014 15:05:06 -0000 Received: from EMEA1-MTA by nat28.tlf.novell.com with Novell_GroupWise; Mon, 17 Feb 2014 15:05:05 +0000 Message-Id: <5302332D020000780011CEF1@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.2 Date: Mon, 17 Feb 2014 15:05:01 +0000 From: "Jan Beulich" To: "George Dunlap" , "Yang Z Zhang" ,"Tim Deegan" References: <20140210080314.GA758@deinos.phlegethon.org> <20140211090202.GC92054@deinos.phlegethon.org> <20140211115553.GB97288@deinos.phlegethon.org> <52FA2C63020000780011B201@nat28.tlf.novell.com> <52FA480D.9040707@eu.citrix.com> <52FCE8BE.8050105@eu.citrix.com> <52FCF90F020000780011C29A@nat28.tlf.novell.com> <20140213162022.GE82703@deinos.phlegethon.org> <5301F000020000780011CCE0@nat28.tlf.novell.com> <53022209.1060005@eu.citrix.com> In-Reply-To: <53022209.1060005@eu.citrix.com> Mime-Version: 1.0 Content-Disposition: inline Cc: "andrew.cooper3@citrix.com" , Xiantao Zhang , "xen-devel@lists.xen.org" Subject: Re: [Xen-devel] [PATCH] Don't track all memory when enabling log dirty to track vram X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org >>> On 17.02.14 at 15:51, George Dunlap wrote: > On 02/17/2014 10:18 AM, Jan Beulich wrote: >> Actually I'm afraid there are two problems with this patch: >> >> For one, is enabling "global" log dirty mode still going to work >> after VRAM-only mode already got enabled? I ask because the >> paging_mode_log_dirty() check which paging_log_dirty_enable() >> does first thing suggests otherwise to me (i.e. the now >> conditional setting of all p2m entries to p2m_ram_logdirty would >> seem to never get executed). IOW I would think that we're now >> lacking a control operation allowing the transition from dirty VRAM >> tracking mode to full log dirty mode. > > Hrm, will so far playing with this I've been unable to get a localhost > migrate to fail with the vncviewer attached. Which seems a bit strange... Not necessarily - it may depend on how the tools actually do this: They might temporarily disable log dirty mode altogether, just to re-enable full mode again right away. But this specific usage of the hypervisor interface wouldn't (to me) mean that other tool stacks might not be doing this differently. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel